Complete the set of trunc/floor/ceil lemmas #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
proux01
force-pushed
the
floor_ceil_trunc
branch
from
6616166 to
6a18846
Compare
CohenCyril
reviewed
Mar 27, 2025
classical/mathcomp_extra.v
Outdated
| @@ -512,82 +542,258 @@ Qed. | |||
|
|
|||
| End order_min. | |||
|
|
|||
| Lemma intrD1 {R : ringType} (i : int) : i%:~R + 1 = (i + 1)%:~R :> R. | |||
| Lemma intr1 {R : ringType} (i : int) : i%:~R + 1 = (i + 1)%:~R :> R. | |||
There was a problem hiding this comment.
This should rather be be addz1r
There was a problem hiding this comment.
So we would have?
Lemma addzr1 {R : ringType} (i : int) : i%:~R + 1 = (i + 1)%:~R :> R.
Lemma addz1r {R : ringType} (i : int) : 1 + i%:~R = (1 + i)%:~R :> R.Not so convinced since the integer addition is on the RHS of the equality.
There was a problem hiding this comment.
Anyway, FYI, it was decided yesterday to drop that commit from the current PR.
affeldt-aist
force-pushed
the
floor_ceil_trunc
branch
2 times, most recently
from
5d92eaa to
fda93d2
Compare
similarly to intr_int or natr_nat already in mathcomp
proux01
force-pushed
the
floor_ceil_trunc
branch
from
fda93d2 to
f718ff3
Compare
proux01
force-pushed
the
floor_ceil_trunc
branch
from
f718ff3 to
465cfa4
Compare
|
This implements what was decided during last sharing day and CI is green so let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Complete the set of lemmas about trunc/ceil/floor before backporting them to MathComp (c.f. math-comp/math-comp#1359 )
Checklist
CHANGELOG_UNRELEASED.mdadded corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers